search

etotheipi / BitcoinArmory

Python-Based Bitcoin Software
Other
826 stars 618 forks source link

RPM: Add armory.spec and armory.spec.README #292

Closed josephbisch closed 9 years ago

josephbisch commented 9 years ago

@droark

This is an example armory.spec that can be used to build an RPM package of Armory. As it is capable of building version 0.93.1 from the GitHub tarball. It should also be capable of building previous versions by just changing all instances of the version 0.93.1 to whatever version you are trying to build.

Note that I put an armory.spec.autotools that should work with the new autotools build system, but I haven't tried building that or running it yet.

As the README says in the note at the end. I have been able to run the RPM generated on my Debian Jessie machine on a Fedora 21 system.

Since this just involves two files (the source and the spec) and one command (rpmbuild), I didn't bother trying to write a script to automate it, especially considering that there may be some slight difference that I am not aware of in the way things are to be done if building on or building for a particular platform.

droark commented 9 years ago

Looks fine overall. My only request is to put a much larger warning in the README. It should be clearer that this is experimental and things may not work.

josephbisch commented 9 years ago

@droark - I added a short warning. Let me know if the warning isn't worded correctly or if I went overboard with the "WARNING" strings that I surrounded the warning with.

droark commented 9 years ago

@josephbisch - The warning looks fine. I just want people to understand that, for now at least, this isn't officially supported. If it is later, or people want to contribute patches (assuming you don't first), cool, but it's something we've got in our back pocket for now.