etpinard / dash-textarea-autocomplete

Dash component wrapper for `react-textarea-autocomplete`
MIT License
13 stars 1 forks source link

Add build fixups + use Artifacts #13

Closed Felix-Gauthier closed 2 years ago

Felix-Gauthier commented 2 years ago

This is following 2 other closed PRs (#10 and #12) made I was getting familiar working with a "Dash component project", so to speak.

Third time's the charm!

Resolves #11

To-do:

Felix-Gauthier commented 2 years ago

Ok so a lot of changes in the last 6 commits, mostly about adding the url value and moving the postbuild stuff to a separate file, as well as committing the deps tarball to the repo.

I think this should be good for final review pass and version bump, but we have to be extra sure the url should work before merging & tagging : it's not dramatic if we have to do a v1.2.1 to correct it but it would be nice to get it right on the first try.

etpinard commented 2 years ago

Awesome. This looks great! After adding one line in the CONTRIBUTING.md file, I'd be happy with giving this a go!

I think this should be good for final review pass and version bump, but we have to be extra sure the url should work before merging & tagging : it's not dramatic if we have to do a v1.2.1 to correct it but it would be nice to get it right on the first try.

Right, I don't mind giving this v1.2.0 a shot and quickly make a fix in v1.2.1 if things don't work. Let's be honest, this project isn't that popular (yet :upside_down_face: )

That said, releasing this thing isn't that simple. Make sure you review

https://github.com/etpinard/dash-textarea-autocomplete/blob/main/CONTRIBUTING.md#create-a-production-build-and-publish

namely, you'll need an https://www.npmjs.com/ account (to publish the javascript package), https://pypi.org/ account (to publish the python package) and then I'll need to add you as a contributor to both registries.

etpinard commented 2 years ago

Right, I don't mind giving this v1.2.0 a shot and quickly make a fix in v1.2.1

An important corollary here: let's not try do this on a Friday afternoon. Mondays are much better for these sort of things :smile: