Open bcsgh opened 1 year ago
Some digging around for other reason shows that http_endpoint::operator< is unconditionally case-insensitive. This strongly implies that there are gaps in the test suite relating to builds with -DCASE_INSENSITIVE.
http_endpoint::operator<
-DCASE_INSENSITIVE
Play around with this: https://github.com/etr/libhttpserver/pull/309/commits/518a966890d595b5889dd9966f488ac65adda319
Expected behavior: Test coverage both with and withou -DCASE_INSENSITIVE and the cases where they differ.
Actual behavior: A test I added for one case surfaced a bug.
Current master.
Prerequisites
Description
Some digging around for other reason shows that
http_endpoint::operator<
is unconditionally case-insensitive. This strongly implies that there are gaps in the test suite relating to builds with-DCASE_INSENSITIVE
.Steps to Reproduce
Play around with this: https://github.com/etr/libhttpserver/pull/309/commits/518a966890d595b5889dd9966f488ac65adda319
Expected behavior: Test coverage both with and withou
-DCASE_INSENSITIVE
and the cases where they differ.Actual behavior: A test I added for one case surfaced a bug.
Versions
Current master.