etr / libhttpserver

C++ library for creating an embedded Rest HTTP server (and more)
GNU Lesser General Public License v2.1
882 stars 184 forks source link

[BUG] Test coverage for -DCASE_INSENSITIVE is lacking. #310

Open bcsgh opened 1 year ago

bcsgh commented 1 year ago

Prerequisites

Description

Some digging around for other reason shows that http_endpoint::operator< is unconditionally case-insensitive. This strongly implies that there are gaps in the test suite relating to builds with -DCASE_INSENSITIVE.

Steps to Reproduce

Play around with this: https://github.com/etr/libhttpserver/pull/309/commits/518a966890d595b5889dd9966f488ac65adda319

Expected behavior: Test coverage both with and withou -DCASE_INSENSITIVE and the cases where they differ.

Actual behavior: A test I added for one case surfaced a bug.

Versions

Current master.