etrepat / baum

Baum is an implementation of the Nested Set pattern for Laravel's Eloquent ORM.
http://etrepat.com/baum
MIT License
2.24k stars 459 forks source link

Call to undefined method `immediateDescendants()` #326

Open kheengz opened 4 years ago

kheengz commented 4 years ago

Laravel: 6.0 Baum: 2.0.0-alpha1

i had to check the codebase and i realized that some portion of codes were commented out. actually this bit here https://github.com/etrepat/baum/blob/v2/src/NestedSet/Concerns/Relatable.php#L27-L45

    // /**
    //  * Inmmediate descendants relation. Alias for "children".
    //  *
    //  * @return \Illuminate\Database\Eloquent\Relations\HasMany
    //  */
    // public function immediateDescendants()
    // {
    //     return $this->children();
    // }
    // /**
    //  * Attribute alias so as to eager-load the proper relationship.
    //  *
    //  * @return mixed
    //  */
    // public function getImmediateDescendantsAttribute()
    // {
    //     return $this->getRelationValue('children');
    // }

the way i was able to get around this challenges were to override that function or rather duplicate it into my own class that inherited the Buam/Node by doing this below.

      /**
      * Inmmediate descendants relation. Alias for "children".
      *
      * @return \Illuminate\Database\Eloquent\Relations\HasMany
      */
     public function immediateDescendants()
     {
         return $this->children();
     }