Closed VoltCruelerz closed 2 years ago
Awesome! I'll take a look tonight! Thanks for attaching the broken actor. 😀
OK, this is happening because the legendary action itself is referencing another action... I previously had logic that could handle this but cleaned it up to just reference anything that is listed as a Legendary Action and assume that action was the action to execute. That's one way for you to fix this without any change on my side.
I'll look into adding this referential logic back in, but it will be more error prone than the above model. Basically I'm relying on correctly parsing the attack text correctly to see and then making a match with an existing item. It would be fairly simple in this case but I could foresee slight misspellings or references being slightly off, which would cause this to miss. For example, I had seen on some characters, "Actor makes a sword attack" and then the sword is named "Lightbringer". So it's quite difficult to make that inference in that case.
But I'll add this as a fall back if I find that there is nothing interesting in the attack for the first pass! This will always be a best-case type scenario. :)
Resolved in release 1.0.13
https://github.com/etriebe/combat-estimate/releases/tag/1.0.13
While #10 is resolved in the sense that it's no longer drawing a blank on the popup, it still seems to not be calculating the legendary action in a meaningful way.
Here is the json of the creature in question (which is not the one found on D&D Beyond):