search

etriebe / combat-estimate

MIT License
4 stars 1 forks source link

>100% Accuracy #8

Closed VoltCruelerz closed 2 years ago

VoltCruelerz commented 2 years ago

The accuracy formula seems to not be bounded appropriately as you can't have >100% accuracy (as seen on Farrock's trident, circled below, and Finnian's spellbook).

image
etriebe commented 2 years ago

I think this should be resolved already with 1.0.10. Can you upgrade and try again?

--Eric Triebe

From: Michael Greene @.> Sent: Sunday, May 8, 2022 3:46:05 PM To: etriebe/combat-estimate @.> Cc: Subscribed @.***> Subject: [etriebe/combat-estimate] Natural 1 Accuracy (Issue #8)

The accuracy formula seems erroneous, which I assume is due to not accounting for natural 1s being automatic misses.

[image]https://user-images.githubusercontent.com/4068550/167318907-cf4c8528-67f7-443f-aae0-7326c7b5f7ac.png

— Reply to this email directly, view it on GitHubhttps://github.com/etriebe/combat-estimate/issues/8, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZH2OEKMZCSMSLKLIV7AK3VJA723ANCNFSM5VMR6O7A. You are receiving this because you are subscribed to this thread.Message ID: @.***>

VoltCruelerz commented 2 years ago

Ah, yep. That did it. Closing.

etriebe commented 2 years ago

All good! It had just released! Glad it's resolved.

--Eric Triebe

From: Michael Greene @.> Sent: Monday, May 9, 2022 10:05:13 AM To: etriebe/combat-estimate @.> Cc: Eric Triebe @.>; Comment @.> Subject: Re: [etriebe/combat-estimate] >100% Accuracy (Issue #8)

Ah, yep. My mistake. Closing.

— Reply to this email directly, view it on GitHubhttps://github.com/etriebe/combat-estimate/issues/8#issuecomment-1121353737, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZH2ODJPJKLRILXYCIYHVTVJFAUTANCNFSM5VMR6O7A. You are receiving this because you commented.Message ID: @.***>