etriebe / dnd-randomizer

GNU General Public License v3.0
6 stars 4 forks source link

[Bug] PF2e unable to index compendiums, resulting in no actors being used in generation. #91

Closed Derinzed closed 7 months ago

Derinzed commented 9 months ago

Foundry version: 10 Foundry Build: 303

PF2e System version: 4.12.9

Description: As stated in the title, if you open the creature codex with a fresh install (not disabling or altering filters) you will receive no actors in the list. If you open the inspection menu, you will notice multiple errors stating that the compendiums could not be indexed. This results in the generator being unable to create encounters with valid actors and the codex being left empty. This was reproducible in a fresh world without any other modules. Images below showing the errors:

image

etriebe commented 9 months ago

Ah, creature codex shouldn't work for pf2e since they already have the creature browser, I think, as part of built in PF2E.

etriebe commented 9 months ago

But I will fix it to not let the button appear for PF2E.

Derinzed commented 9 months ago

Awesome i appreciate it. As a followup question...is it expected that when you generate encounters, all encounters display "missing level x" and do not spawn creatures?

etriebe commented 9 months ago

Do you have a screenshot and a copy of console logs I can look at,

Get Outlook for iOShttps://aka.ms/o0ukef


From: Derinzed @.> Sent: Monday, February 19, 2024 10:43:42 AM To: etriebe/dnd-randomizer @.> Cc: Eric Triebe @.>; Comment @.> Subject: Re: [etriebe/dnd-randomizer] [Bug] PF2e unable to index compendiums, resulting in no actors being used in generation. (Issue #91)

Awesome i appreciate it. As a followup question...is it expected that when you generate encounters, all encounters display "missing level x" and do not spawn creatures?

— Reply to this email directly, view it on GitHubhttps://github.com/etriebe/dnd-randomizer/issues/91#issuecomment-1953010880, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZH2ODTWIOVH56NSDZXVC3YUOMN5AVCNFSM6AAAAABDORK3U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGAYTAOBYGA. You are receiving this because you commented.Message ID: @.***>

Derinzed commented 9 months ago

Sure. Here's a screen of the generator:

image

Same thing will happen across any selection.

etriebe commented 9 months ago

OK, so what creatures do you have selected and what filter settings?

Derinzed commented 9 months ago

All creatures are enabled. I don't have any filters, yet it still displays 0 available creatures:

image

image

Derinzed commented 9 months ago

Also, if it's helpful information. I'm using all compendiums, and have a filter with 3 level 3 players.

Derinzed commented 9 months ago

For kicks and giggles, I updated to foundry V.11. It appears to be working as intended now. I'm guessing this is only an issue in V10, but I'm going to downgrade and see.

Edit: Can confirm, this is an issue with V10 only.

etriebe commented 8 months ago

Let me try and figure out what fix broke this for V10 and add a v10 vs v11 pivot.

Derinzed commented 8 months ago

Sounds good. I did get it to work previously. Under Scripts/Utils/ActorUtils.js I changed line 25:

image

To be honest I'm not sure if everything works 100% as expected as I hadn't tested much before hand, but this does appear to resolve the issue on a surface level.

etriebe commented 7 months ago

Fixed with latest release.