search

etrombly / rust-crosscompile

docker for cross compiling rust gtk programs to windows
35 stars 6 forks source link

Clean up package directory #5

Closed etrombly closed 3 years ago

etrombly commented 3 years ago

Currently package.sh doesn't clean the package directory before copying everything. There could be artifacts from a previous build there.

ajmcmiddlin commented 3 years ago

I believe this is now fixed, as package gets deleted if it exists. However, my preference would be to abort the build if it exists, so we don't accidentally delete unrelated data in the source directory. Then, move the delete to the end of the script after the zip has been produced. I can PR something if you want.

etrombly commented 3 years ago

I just moved the package directory deletion to the end. You may need to manually clean it up on any existing projects once. Thanks for the recommendation.