ets-labs / python-dependency-injector

Dependency injection framework for Python
https://python-dependency-injector.ets-labs.org/
BSD 3-Clause "New" or "Revised" License
3.86k stars 303 forks source link

Circular dependency in wiring #764

Open krunaldodiya opened 10 months ago

krunaldodiya commented 10 months ago

I am facing the circular dependency issue:

from dependency_injector import containers, providers

from trader.core.args_manager import ArgsManager
from trader.core.api import Api

class Container(containers.DeclarativeContainer):
    config = providers.Configuration()

    args_manager = providers.Singleton(
        ArgsManager,
    )

    api = providers.Singleton(
        Api,
    )
from dependency_injector.wiring import Provide, inject

class ArgsManager:
     @inject
     def __init__(self, api = Provide["api"]):
            print(api)
class Api:
     def __init__(self):
            pass

print(api) gives instance of dependency_injector.wiring.Provide instead of Api

if I add wire, it gives circular import error.

ArgsManager requires Container and Container requires ArgsManager

from dependency_injector.wiring import Provide, inject

class ArgsManager:
     @inject
     def __init__(self, api = Provide["api"]):
            print(api)

if __name__ == "__main__":
    container = Container()
    container.wire(modules=[__name__])

How to solve this ?

Originally posted by @krunaldodiya in https://github.com/ets-labs/python-dependency-injector/issues/327#issuecomment-1806778284

benm5678 commented 6 months ago

I'm facing the same issue. I almost get the sense you can only inject objects that don't depend on the container (or any of their dependencies do).... but that makes it so much weaker than other DI frameworks I've used. Does anyone have some solution or another recommendation?