search

ets-labs / python-vimrc

VIM Configuration for Python / Cython / C Development
BSD 3-Clause "New" or "Revised" License
652 stars 343 forks source link

pymode_doc_key name changed to pymode_doc_bind in 0.7.8b #33

Closed alphaCTzo7G closed 6 years ago

alphaCTzo7G commented 7 years ago

Hi

In this line, it uses pymode_doc_key: https://github.com/ets-labs/python-vimrc/blob/ab61240211959ae171c8b4f46c5f1153734bb803/vimrc#L169

However, python-mode has change the variable name pymode_doc_key to pymode_doc_bind in version 0.7.8b (https://github.com/python-mode/python-mode/blob/b848f6294ca5858fd17eaf14783fa2042e8142b7/Changelog.rst#L81).

Would you it be ok, if I do a PR to update the variable?

rmk135 commented 7 years ago

Hi there,

Yeah, definitely! Please, go ahead!

... Didn't know about this. I would merge it ASAP.

Thanks a lot, Roman

rmk135 commented 7 years ago

Hi @alphaCTzo7G ,

How are you? Just wanted to ask you if you still plan to propose PR for fixing this problem?

Thanks, Roman

rmk135 commented 6 years ago

Fixed in https://github.com/ets-labs/python-vimrc/commit/18574648b741e571cdfc29340b7e3e2ee03e2400.