ets / tap-spreadsheets-anywhere

GNU Affero General Public License v3.0
31 stars 62 forks source link

BUG: pulling excel files from s3 path do not work (but works fine on rfainc version) #84

Open ciocan opened 4 months ago

ciocan commented 4 months ago
2024-07-16T10:57:25.890644Z [error    ] Cannot start plugin tap-spreadsheets-anywhere-<redacted-name>: Catalog discovery failed: command ['/<redacted>/.meltano/extractors/tap-spreadsheets-anywhere/venv/bin/tap-spreadsheets-anywhere', '--config', '/<redacted>/.meltano/run/tap-spreadsheets-anywhere-<redacted-name>/tap.71d7af1f-b787-4813-bd0e-40098e963836.config.json', '--discover'] returned 1 with stderr:
 INFO Found credentials in environment variables.
INFO Found 43 files.
INFO Checking 43 resolved objects for any that match regular expression "<redacted_file_name>.xlsx" and were modified since 2024-01-01 00:00:00+00:00
INFO Processing 1 resolved objects that met our criteria. Enable debug verbosity logging for more details.
INFO Sampling <redacted_file_name>.xlsx (1000 records, every 5th record).
ERROR Unable to write Catalog entry for '<redacted_project_name>' - it will be skipped due to error [Errno 2] No such file or directory: '<redacted_file_name>.xlsx'
CRITICAL [Errno 2] No such file or directory: '<redacted_file_name>.xlsx'

Using the same config table item - s3 path, file name and the rest works fine with the rfainc variant.

ffmc-mayank commented 1 month ago

I also faced this issue. I spent some time trying to figure out and I believe (after doing some testing locally), this issue was introduced as a side effect of this change in the PR. @craigastill will you be able to help with figure out how to fix this since you made this change to address some other issue? When I remove .name, it works just fine (locally).