etsap-TIMES / xl2times

Open source tool to convert TIMES models specified in Excel
https://xl2times.readthedocs.io/
MIT License
12 stars 7 forks source link

CI: fix bug in parsing additional lines #195

Closed siddharth-krishna closed 9 months ago

siddharth-krishna commented 9 months ago

Fixes a bug in the parsing of additional lines by the regression tests introduced in #190: https://github.com/etsap-TIMES/xl2times/pull/190/files#diff-cca48a967a9c20b6fc94f3c37310d00cd4c05e08fea487fafe27ab770590ec2bR38

Which causes the test to use the total lines as additional lines:

image

I manually compared the additional rows to the last run on the main branch before the bug to ensure that there have been no regressions in additional rows in the meanwhile. 🚀

SamRWest commented 8 months ago

Sorry about this @siddharth-krishna, hope it didn't take too long to spot this one!

siddharth-krishna commented 8 months ago

No worries at all. :)