search

etsap-TIMES / xl2times

Open source tool to convert TIMES models specified in Excel
https://xl2times.readthedocs.io/
MIT License
12 stars 7 forks source link

Use groupby to speed up user constraints #205

Closed siddharth-krishna closed 8 months ago

siddharth-krishna commented 8 months ago

(I wanted to make a quick PR to test ReadTheDocs integration.)

This PR implements the suggestion from #185 on the code introduced by #179 (https://github.com/etsap-TIMES/xl2times/pull/179/files/4ea76267c9558b3a08d09ec282b7a5fcaa458f8c#r1489079776) and gets 3% runtime improvement on my laptop.

siddharth-krishna commented 8 months ago

Sadly, RTD is still not happy:

Could not send GitHub build status report for "xl2times". Make sure you have the correct GitHub repository permissions and your GitHub account is connected to Read the Docs.

I had tried to manually add the webhooks, but RTD is still not able to report build status back to the GitHub PR as in this example: image

Perhaps it will still build a new docs site when this PR is merged into main? Let's see 🤞

siddharth-krishna commented 8 months ago

The GitHub-RTD link is working in one direction, so even though the PR doesn't show it, RTD has built docs for this PR: https://xl2times--205.org.readthedocs.build/en/205/

olejandro commented 8 months ago

Ok, so we merge this and keep #185 open as a reminder to make improvements in other parts of the code?