search

etscrivner / rbsecp256k1

Compiled Ruby wrapper around libsecp256k1 for secp256k1 ECDSA.
The Unlicense
19 stars 13 forks source link

Removed require 'rbsecp256k1/rbsecp256k1' from lib/rbsecp256k1.rb #62

Closed schinery closed 1 year ago

schinery commented 1 year ago

Fix for https://github.com/etscrivner/rbsecp256k1/issues/61 which I've tested in my previously failing app using gem "rbsecp256k1", git: "https://github.com/schinery/rbsecp256k1".

Also updated the test matrix to include Ruby 3.1 and 3.2.

q9f commented 1 year ago

👍🏼 makes sense. let's see what the CI says.

etscrivner commented 1 year ago

@schinery I've fixed the issue with failing workflow tests. If you can rebase against master and push up again we can see if tests pass.

EDIT: Nevermind, looks like you got it.

etscrivner commented 1 year ago

@schinery IIRC rbsecp256k1/rbsecp256k1 refers to the shared object found in the rbsecp256k1 library folder, not a Ruby file, so it cannot be simply removed and I don't think the issue is simply an invalid import.

schinery commented 1 year ago

@etscrivner ah yeah, seems like that 😢

schinery commented 1 year ago

@etscrivner I'll close this and do a PR just for updating the test matrix