search

etsy / 411

An Alert Management Web Application
https://demo.fouroneone.io
MIT License
969 stars 112 forks source link

Disable date-selection for Search types that don't have a concept of time #114

Open kiwiz opened 7 years ago

kiwiz commented 7 years ago

The Search management UI allows you to both test and execute searches against a specific point in time. This is useful for search types like Elasticsearch (via @timestamp) but is meaningless for searches that have no concept of time (like HTTP). In the latter case, we should just hide the time selection functionality (The wrench icon).

The isTimeBased method on Searches will tell you whether these elements should be visible, but it varies depending on which source (in the case of Elasticsearch, which cluster) you're targeting. We'd need a bit of js to check the current source cluster and hide/show the buttons accordingly.

quintanilhar commented 6 years ago

Could you @kiwiz give more details about this issue?

kiwiz commented 6 years ago

Some details added.

quintanilhar commented 6 years ago

Hey @kiwiz, could I get this issue?

kiwiz commented 6 years ago

~Yup, assigned to you!~ Hmm, you don't show up on the list of assignable users. 🤷‍♂️

quintanilhar commented 6 years ago

It's weird, in the #145 you did. Anyway, I'm working on this :)