search

etsy / 411

An Alert Management Web Application
https://demo.fouroneone.io
MIT License
969 stars 112 forks source link

Slack notifications: trailing '/' after hostname #148

Closed rozling closed 6 years ago

rozling commented 6 years ago

Hi, thanks for the great project!

I'm seeing an issue with Slack notifications: the link to the alert page fails to render as a link in Slack, because 411 is adding an extra / character after the hostname, e.g:

[<http://411.env.mydomain.net//alert/42|Alert>]

I'm reasonably sure I entered the hostname without a trailing / while creating the site, but can't check where this is stored or change it from the UI

kiwiz commented 6 years ago

You can check by hitting http://411.env.mydomain.net/api/data via the Host field. There's no UI to change this, but you can update the site table in the database.

kiwiz commented 6 years ago

Opps, you're right. We're inserting an extra / in the Site::urlFor method.

kiwiz commented 6 years ago

I've pushed out a fix. Feel free to close this ticket if it resolves the problem.

rozling commented 6 years ago

Can confirm that this resolves the issue, thanks!