search

etsy / 411

An Alert Management Web Application
https://demo.fouroneone.io
MIT License
971 stars 112 forks source link

[WIP] Add support for authentication via SAML Proxy #79

Closed nevins-b closed 7 years ago

nevins-b commented 8 years ago

This is initial work to add support for running 411 behind a SAML proxy and as such bypassing the normal authentication mechanism.

This is inspired by grafana's auth.proxy https://blog.raintank.io/authproxy-howto-use-external-authentication-handlers-with-grafana/

This works but is a little ugly in some ways, any feed back on how to make it nicer would be much appreciated.

kiwiz commented 8 years ago

I like this. It's similar to what we use internally. However, I'm not sure if I want this within 411 or just a separate plugin repo. Going to have a think about plugin architecture.

kiwiz commented 7 years ago

I'd like to add most of this functionality directly in the Auth.php class. If you'd like I can merge this change and then just apply my changes on top.

nevins-b commented 7 years ago

That's fine with me, whatever is easiest.

kiwiz commented 7 years ago

Hey again. Could you resubmit a PR against the https://github.com/etsy/411/tree/auth branch? I'd like to keep work on this feature there till we're done.

kiwiz commented 7 years ago

Continuing work in #95.