etsy / boundary-layer

Builds Airflow DAGs from configuration files. Powers all DAGs on the Etsy Data Platform
Apache License 2.0
262 stars 58 forks source link

Add master_type parameter to ml_engine_training operator #55

Closed vchiapaikeo closed 4 years ago

vchiapaikeo commented 4 years ago

Airflow versions prior to 1.10.4 are missing a master_type parameter to the MLEngineTrainingOperator. This is resolved going forward but is also handled in patch AIRFLOW-3624 that we recently applied to our Airflow.

The latest stable version of Airflow has this parameter (along with all Airflows released after 1.10.4). https://airflow.apache.org/docs/stable/_api/airflow/contrib/operators/mlengine_operator/index.html#airflow.contrib.operators.mlengine_operator.MLEngineTrainingOperator

mchalek commented 4 years ago

@vchiapaikeo I'll leave it to you to merge (or tell me when it's ready) and once you do i'll deploy the new artifact.

vchiapaikeo commented 4 years ago

Ah @mchalek , missed that note. I actually don't have merge abilities - but I am ready to merge whenever you are. Thank you!

mchalek commented 4 years ago

ah! so you don't. OK i'll do it now.

vchiapaikeo commented 4 years ago

Thanks! :-)