Closed jmchen28 closed 4 years ago
oh interesting, thanks for this addition @jmchen28 ! I will have to take some time later this week to give it a closer look, but on the surface I think I follow the reasoning and I think it makes sense.
thanks! for more context, we have a custom plugin that adds 3 operators downstream of a given task id.
right now, when we add the plugin to the top of the DAG definition and the plugin's upstream task uses generators, boundary-layer throws an error at the build step because the upstream node is not part of the primary graph and has not yet been added.
adding the plugin to the sub-graph results in a parse error, because plugin_config
is not recognized. this change allows plugin use in sub-graphs.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
boundary_layer/workflow.py | 12 | 14 | 85.71% | ||
boundary_layer/schemas/dag.py | 5 | 11 | 45.45% | ||
<!-- | Total: | 17 | 25 | 68.0% | --> |
Totals | |
---|---|
Change from base Build 189: | 0.06% |
Covered Lines: | 2103 |
Relevant Lines: | 2404 |
Allow plugins to be evaluated within generator sub-workflows so any operators that may be added by the plugin are added to the correct subgraph.
usage: