Documented the intended Node version to install with nvm by adding a .nvmrc file (based on this), as I wanted to make sure I was running npm commands on my host machine with the proper Node+NPM version.
As far as I can tell, all usage of Promise in kevin-middleware is native spec compliant and there's no code changes necessary aside from deleting the module import.
Description
.nvmrc
file (based on this), as I wanted to make sure I was runningnpm
commands on my host machine with the proper Node+NPM version.package-lock
to be upgraded as npm >= 7 uses the updated lockfile format https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-jsonAs far as I can tell, all usage of
Promise
in kevin-middleware is native spec compliant and there's no code changes necessary aside from deleting the module import.Context / Why are we making this change?
kevin/buildapack is running on Node 16 and bluebird polyfill for Node is no longer necessary https://etsy.atlassian.net/jira/software/c/projects/WBI/boards/447?modal=detail&selectedIssue=WBI-270
Testing and QA Plan
pulled and linked this branch of kevin on my dev vm & restarted buildapack
npm test
also passes