etsy / nagios-herald

Add context to Nagios alerts
https://codeascraft.com/2014/06/06/introducing-nagios-herald/
MIT License
321 stars 32 forks source link

Removing Helpers namespace to standardize on Helper #42

Closed ryndaniels closed 8 years ago

ryndaniels commented 8 years ago

It turned out that we had two namespaces for helpers - Helper and Helpers. The helpers themselves all use Helper, but other formatters and helpers were using Helpers. Not only is this confusing, but it's inconsistent with how the Formatter and Message namespaces are used. This commit changes this to properly reference Helper, and adds an example of a test case that might have caught this.

aemcknig commented 8 years ago

This looks good and appears to fix the issues that we were seeing! Good catch. 🌷 🐘

RyanFrantz commented 8 years ago

Thanks for tidying up the namespace @kdaniels!