etsy / oculus

The metric correlation component of Etsy's Kale system
http://codeascraft.com/2013/06/11/introducing-kale/
Other
707 stars 72 forks source link

Elasticsearch 0.90.x support #13

Closed banzayats closed 10 years ago

banzayats commented 10 years ago

Is there any plans in the near future to make oculus compatible with elasticsearch 0.90.x?

jonlives commented 10 years ago

Hi there - there is indeed, PR #8 already adds the functionality. I'm waiting for some new hardware to arrive at this end, then hope to get this tested and released in the next couple of weeks.

banzayats commented 10 years ago

Trying to build plugin:

cd /usr/share/elasticsearch/elasticsearch-oculus-plugin
rake build

and get error:

com/etsy/oculus/tsscorers/DTWScript.java:34: error: cannot find symbol
          String current_value = doc().field(comparison_field).stringValue();
                                      ^
  symbol:   method field(String)
  location: class DocLookup
com/etsy/oculus/tsscorers/EuclidianScript.java:28: error: cannot find symbol
          String current_value = doc().field(comparison_field).stringValue();
                                      ^
  symbol:   method field(String)
  location: class DocLookup
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
rake aborted!
Command failed with status (1): [javac 'com/dtw/CostMatrix.java' 'com/dtw/D...]
/usr/share/elasticsearch/elasticsearch-oculus-plugin/Rakefile:4:in `block in <top (required)>'
/usr/local/rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => build => compile
(See full trace by running task with --trace)
jonlives commented 10 years ago

@banzayats was this trying to build the current plugin in master against 0.9.x, or the plugin code from PR #8? Master is known to not build against ES 0.9 - that's the bit I'm working on

banzayats commented 10 years ago

My fault. I've tried to build plugin in master. Than I've applied diff from PR #8 and got OculusPlugins.jar without problems. Elasticsearch version - 0.90.7

jonlives commented 10 years ago

@banzayats excellent - that actually helps me double verify that the PR is good too :p I'll try to get this merged and into master as soon as possible.

jonlives commented 10 years ago

Closing this off now as PR #8 has now been merged into master