search

etsy / opsweekly

On call alert classification and reporting
MIT License
761 stars 100 forks source link

Fixed the alert urgency on Pagerduty oncall provider. #59

Closed ninoabbate closed 8 years ago

ninoabbate commented 8 years ago

The Pagerduty oncall provider ignores completely the urgency of an alert, it sets by default every alerts to critical.

lozzd commented 8 years ago

Thanks for this! Does the Pagerduty "urgency" match up with the Nagios states? E.g. CRITICAL, WARNING? If so this looks good, I'm just concerned about urgencies coming in that don't have styles configured that might look a bit weird in the UI (e.g. Critical comes out red, etc).

Thanks!

ninoabbate commented 8 years ago

You're welcome! The urgency is the "Notification Urgency" field you setup on each service in Pagerduty. Since Opsweekly is used for reporting, it is better if this field reflects the Pagerduty field instead of marking everything critical. The UI as it is doesn't seem weird, maybe it could be a good thing to add more colours for HIGH and LOW urgencies.

lozzd commented 8 years ago

Sounds good to me! I'll accept this as is then, if you fancy adding some tag colouring, please do!