search

etsy / sbt-checkstyle-plugin

SBT Plugin for Running Checkstyle on Java Sources
MIT License
32 stars 25 forks source link

Use checkstyle-check to fail build on warnings or errors #10

Closed josephearl closed 8 years ago

josephearl commented 8 years ago

Fixed #8. Ported from https://github.com/Redmart/sbt-checkstyle-plugin, refactored to avoid duplicate code.

Adds checkstyle-check task and checkstyleCheckSeverityLevel setting.

josephearl commented 8 years ago

I have fixed https://github.com/Redmart/sbt-checkstyle-plugin/issues/3 and https://github.com/Redmart/sbt-checkstyle-plugin/issues/4 as part of this port, but not https://github.com/Redmart/sbt-checkstyle-plugin/issues/5 yet.

ajsquared commented 8 years ago

Do you want to fix https://github.com/Redmart/sbt-checkstyle-plugin/issues/5 in this PR?

josephearl commented 8 years ago

Yes, let's do that

ajsquared commented 8 years ago

Great, sounds good!

josephearl commented 8 years ago

Fixed issue 5, please review

ajsquared commented 8 years ago

I really appreciate all the pull requests you've sent in! I'm a bit busy this weekend, but I will look over everything on Monday.

josephearl commented 8 years ago

Updated to use Option[CheckstyleSeverityLevel] and removed the checkstyle-check task