search

etsy / skyline

It'll detect your anomalies! Part of the Kale stack.
http://codeascraft.com/2013/06/11/introducing-kale/
Other
2.14k stars 336 forks source link

The UDP MessagePack format description in the wiki is wrong #107

Closed vitorbaptista closed 9 years ago

vitorbaptista commented 9 years ago

Hi,

Currently, https://github.com/etsy/skyline/wiki/Getting-Data-Into-Skyline#udp-messagepack says that:

UDP messagepack

Horizon also accepts metrics in the form of messagepack encoded strings over UDP, on port 2025. > The format is <metric name> <timestamp> <value>. Simply encode your metrics as messagepack and send them on their way.

That's not the case. It actually is [<metric name>, [<timestamp>, <value>]]. I haven't changed the wiki directly, because the format has always been like this (as far as I could find on git's history), so I wonder if the issue was that I didn't interpret it correctly. If that's the case, it would be good to make it clearer, as others might have the same issue.

Thanks!

tracyde commented 9 years ago

I concur, especially with how graphite formats it's messages. After reading the wiki I thought the format was , , until I saw this post and dove into the seed_data.py script. The wiki should be updated (an example of how to do it in ruby would also help).

astanway commented 9 years ago

Updated - good catch folks.

vitorbaptista commented 9 years ago

Thanks, @astanway! Closing this issue.