search

etsy / statsd-jvm-profiler

Simple JVM Profiler Using StatsD and Other Metrics Backends
MIT License
330 stars 93 forks source link

Tracks memory pool stats (eden, survivor, tenured, etc.) #19

Closed bdarfler closed 9 years ago

bdarfler commented 9 years ago

This, along with https://github.com/etsy/statsd-jvm-profiler/pull/18 closes https://github.com/etsy/statsd-jvm-profiler/issues/17

bdarfler commented 9 years ago

Question about this. There is also a type field to denote on/off heap which I didn't use since I wasn't sure how to best add that to the metric name. It would be nice to support graph all pools of the same type together on one graph. Would it be best to have the metric name be type.name to support this? I'm still new to best practices around statsd naming.

ajsquared commented 9 years ago

What do you think of having the metrics like heap.total, heap.eden, etc and group them that way?

Doing this would require some changes to the dashboard, but that should be pretty straightforward.

bdarfler commented 9 years ago

Also I believe there could be spaces in the pool names. Is it best to replace them with a hyphen?

ajsquared commented 9 years ago

Yeah, replacing the spaces with hyphens is good.

bdarfler commented 9 years ago

Ah so you mean like:

heap.total.{init, used, committed, max} heap.eden.{init, used, committed, max}

I like that.

ajsquared commented 9 years ago

Yeah, those metric names look good.

bdarfler commented 9 years ago

Ok I updated the metric names and I took a crack at fixing the visualizer. Let me know if I missed anything.

ajsquared commented 9 years ago

Looks great, thanks again for this!