Changes to run with long running processes.

etsy / statsd-jvm-profiler

Simple JVM Profiler Using StatsD and Other Metrics Backends

MIT License

330 stars 93 forks source link

Changes to run with long running processes. #29

Closed jfenc91 closed 8 years ago

jfenc91 commented 8 years ago

Sorry to lump all these features together on you. I can spend some time to separate them if you are only interested in certain ones. I have been running this on several Elasticsearch 1.7 clusters since I reported the issue. Feel free to review, I will try to get back to this to make improvements/write unit tests.

Added port incrementing logic when the configured port is already taken
Added exception handling and a logging endpoint for agents
Added a endpoint to track the number of times metrics have been sent from each agent

ajsquared commented 8 years ago

This all looks great, thanks for this! I had a couple requests, but overall these changes will be great additions to the project.

A lot of these changes touch code where the test coverage is not that great. If you'd like to add tests that would be great, but I'm happy to merge this without and have a follow-up issue for improving the test coverage.

ajsquared commented 8 years ago

Also, feel free to add yourself to the list of contributors: https://github.com/etsy/statsd-jvm-profiler/blob/master/CONTRIBUTING.md#contributors

jfenc91 commented 8 years ago

Thanks so much for the feedback here. It is super appreciated!

ajsquared commented 8 years ago

Thanks again for this!

jfenc91 commented 8 years ago

Thank you! I'm happy to contribute back! This has been a great monitoring/diagnostic tool!