[Bug]: Some wrong values on evaluation screen for score from same chartkey but different starting offset

g-robertson commented 2 years ago

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details

NNNN#9545 on discord

Version Info

Latest available release

What operating system are you seeing the problem on?

Linux (any distro)

Bug Behavior

When setting a score on Jade's OP with a new offset with the beginning cropped out in Vela's Velato v2 my previous score set on a version of it with a longer offset including the beginning shows wrong values

Expected Behavior

Show the correct evaluations results

Reproduction Steps

Set a score on a chart with one offset Change the offset of the chart Set another score The evaluation results of the first score should have inconsistencies when viewed on the second chart

Anything else?

Old score (has wrong values in some places): New score (offset is adjusted, has correct values):

poco0317 commented 2 years ago

need to see the replay files themselves, found in /save/replaysv2 associated with the scorekeys found in etterna.xml

g-robertson commented 2 years ago

sure, old score: Sd549dfcf76d4e1b26acd4df2774e48f0c6471eee.TXT new score: S41df4c2284bb29e94d835f90156a4e89fe1bc622.TXT

poco0317 commented 2 years ago

the problem here is the noterows in the replay data dont match the notedata noterows because of the version change despite the key being the same

problem code will be found in playerai.cpp should consider 0 normalizing notedata and replaydata. this can be done as part of upcoming replay parse/playback rewrites

poco0317 commented 1 year ago

Need confirmation that this issue still exists after 0.72.0+

g-robertson commented 1 year ago

Yes, this is still an issue.

etternagame / etterna