etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
474 stars 133 forks source link

[Feature Request]: Work around openssl1.1 being required but not easily available on modern Ubuntu derivatives #1215

Open bluebandit21 opened 1 year ago

bluebandit21 commented 1 year ago

Is there an existing issue for the feature?

Describe the Feature

Etterna dynamically links in libssl1.1 as a runtime dependency.

Unfortunately, as of Ubuntu 22.04, libssl1.1 is no longer easily available as they have fully deprecated it in favor of libssl3.

As a result, modern Ubuntu and all derivatives require something not easily obtainable even for users using our prebuilt Linux binary.

We should handle this in some fashion or other, either a) Including instructions for acquiring libssl1.1 on modern Ubuntu derivatives b) Trying to fix the root problem, that we require a now-ancient libssl version (can we statically link it in, or upgrade Etterna to use libssl3 instead?)

How Does The Feature Add To The Game?

Currently, users using modern Ubuntu/Ubuntu derivatives are unable to easily build Etterna or even use our pre-built binary without having to obtain a runtime dependency that now requires some technical know-how to obtain.

This problem makes it much harder for new Linux players to be able to play the game.

Additional Context

No response

poco0317 commented 1 year ago

based on this https://cmake.org/cmake/help/latest/module/FindOpenSSL.html

we could probably move required cmake version to 3.19 and change this line with no other issues? https://github.com/etternagame/etterna/blob/23bb8e90634183f998fea7bba83689e26eed9abb/CMakeLists.txt#L71