search

etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
497 stars 135 forks source link

(Again) disable use of libssh2 when building cURL #1221

Closed bluebandit21 closed 1 year ago

bluebandit21 commented 1 year ago

Without this change, we run into the problem where our GHA builder has the libssh2 library installed (and so the built cURL dynamically links to it) but the average mac user does not, leading to the application immediately crashing on start.

This was already fixed once before, but with the recent(ish) upgrade to a newer version of cURL than what we'd been using in f1dd6fe, the option CMAKE_USE_LIBSSH2 was renamed to CURL_USE_LIBSSH2, which silently made our forcing of that setting to OFF no longer work.

jameskr97 commented 1 year ago

I will review this tonight.

nico-abram commented 1 year ago

Looks reasonable to me. For anyone else reviewing, the cmake option is used/defined here

https://github.com/etternagame/etterna/blob/f07cd674bedf3730da2fa3d9f1c79349cc9785d7/extern/curl/CMakeLists.txt#L746

https://github.com/etternagame/etterna/blob/f07cd674bedf3730da2fa3d9f1c79349cc9785d7/extern/curl/CMakeLists.txt#L752-L768