search

etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
474 stars 133 forks source link

[Bug]: BPMDisplay no longer supports random bpm #1230

Closed Malalaika closed 1 year ago

Malalaika commented 1 year ago

Is there an existing issue for this?

Contact Details

No response

Version Info

Latest available release

What operating system are you seeing the problem on?

Windows

Bug Behavior

.sm files set to have a random BPM now display set BPM values in-game

Expected Behavior

.sm files set to have a random BPM should be random; in 0.71 and below the values shuffled between 000, random numbers, and ???

Reproduction Steps

1.) Check out any song that has random bpm enabled; Resonyance Fever should have it.

Anything else?

No response

poco0317 commented 1 year ago

it does support random bpm, but the method we use to set the bpm in the default themes does not enable it.

https://github.com/etternagame/etterna/blob/5acb2a3be336bc6f92b96ef8dd73743f92e84552/src/Etterna/Actor/Menus/BPMDisplay.cpp#L177-L206

poco0317 commented 1 year ago

this issue is a reminder to fix the steps specific function and evaluate the logic involved in populating that field for steps, because it may always be empty anyways

poco0317 commented 1 year ago

checked the logic paths and it seems fine when loaded from disk or from cache, fixed for 0.72.2 24bb49bf929f72a23700bc70b36cd19c55442071