Modify Core::Platform::getLanguage to work with older macOS versions

etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play

https://etternaonline.com/

MIT License

497 stars 135 forks source link

Modify Core::Platform::getLanguage to work with older macOS versions #1237

Closed bluebandit21 closed 1 year ago

bluebandit21 commented 1 year ago

Locale.NSLocale.languageCode was only added in macOS 10.12. However, the same information can be obtained a slightly different way that is non-deprecated and works all the way back to macOS 10.4.

This small change makes Etterna compatible with (at least) El Capitan again excepting the known issue with OpenSSL on High Sierra and earlier users.

bluebandit21 commented 1 year ago

Note (paraphrased from Hidden on Discord): Although 10.10 is the earliest version we theoretically support (based on our root CMakeLists.txt), without this change we only actually support back to 10.12 so it's still relevant.