poco0317
commented
1 year ago testing this in rebirth with wheel banners on for like 5 minutes im finding that this change improves my average fps while holding tab and scrolling from average 40-120 to average 600
I don't use D3D so I don't know if this actually improves things any but it probably does. I think on OpenGL it'll prevent some unnecessary block copies on the music wheel. The main thing is just getting rid of the
blit_rgba_to_rgbamultithreading nonsense. It was basically only ever faster when converting 2048x2048 textures into a format for uploading to the GPU, anything smaller than that and it just sucked up more time than it saved.But that conversion itself was all wrong, anyway. Firstly f017d788857baf65f75632085da1c31c4835a0e6, its basically only ever used for converting images from RGBA to BGRA. RGBA is what OpenGL and everything after D3D10 uses, but D3D9 is from back when everything on Windows wanted to blit directly into GDI handles, so all textures have to be converted to that format when using RageDisplay_D3D. But the code doing that conversion was made for things like RGBA8 to RGBA4--not a byte swap. So just do the byte swap.
Second 8bbb8d82a024548c457ba2c5f37d94246fcb5254, that conversion was happening on every texture reupload, and the game is pretty aggressive about unloading textures, making the texture cache irrelevant. Although I think it's still kind of irrelevant but w/e (and also this matters way less than doing the right kind of blit)