etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
474 stars 133 forks source link

[Bug]: F3 F8 0 to open song's folder doesn't work with songs in folders from AdditionalSongFolders, that are added after the first one #1252

Open velaachlorine opened 1 year ago

velaachlorine commented 1 year ago

Is there an existing issue for this?

Contact Details

No response

Version Info

Latest available release

What operating system are you seeing the problem on?

Windows

Bug Behavior

AdditionalSongFolders in preferences.ini lets you add multiple song folders by separating each path with a comma ( , ) In song wheel, trying to do the combo of F3 F8 0 to open the hovered song's folder, doesn't work if said song is from any path placed after the first comma.

Expected Behavior

No response

Reproduction Steps

e.g. AdditionalSongFolders=U:\EtternaStuff\PrivateSongs,U:\EtternaStuff\Songs If the song you're trying to open the folder of is under that second path, nothing will happen when hitting F3 F8 0

Anything else?

No response

poco0317 commented 10 months ago

the cause of this is due to the filesystem cache, all additionalsongfolders and additionalfolders are mounted in the same place. when you try to resolve a path in a secondary additional folder then the path resolved is rooted in the first listed path instead of any of the subsequent ones. simple fix is to give them unique paths, but song load has to be modified and changing these path names can break some standards that we might not want to break