etternagame / etterna

Advanced cross-platform rhythm game focused on keyboard play
https://etternaonline.com/
MIT License
475 stars 134 forks source link

Find a new use for the option to toggle Marvelous Judgements #424

Closed poco0317 closed 2 years ago

poco0317 commented 5 years ago

This option is in Advanced Options and is referred to as "Fantastic Timing." As this game moves further into being a competitive-focused VSRG, players are more interested in becoming accurate or precise in their taps. There is no reason to turn off Marvelouses, so change it into an option to turn on Ridiculous timing. This will involve changing the judgment file, which means we need to include a fallback judgment in 1x7 form which includes the Ridiculous.

foxfire667 commented 5 years ago

Minor QoL stuff for accuracy is great! If you intend to do game play feedback enhancements like this, what would it take to allow me to enter game play with any judge, but have the official grade on the results screen, and what gets reported to EO, act as if I played on J4?

While I am aware scores uploaded to EO convert the WIFE% to J4, a large issue with swapping judges currently is that it will quickly become a mess in game and on site. Judgements do not reflect J4 when uploaded, and as such can be wildly inconsistent on profile and song leader-board pages, and mess up the judgement accuracy stats on profile. In client, WIFE% is not converted, meaning that grades, performance, and judgements will all be incorrect. Judge swapping basically just means you have to guess which runs are which judges.

Just a toggle to treat all scores as J4 when entering results would reduce tons of headache for trying to use higher judges for that purpose.

Kangaroux commented 5 years ago

483 Related issue to foxfire's comment

poco0317 commented 2 years ago

voided by 613dbc47284c789e77ae46a1523657ef927d57c7 pending closure at merge