search

ettoolong / MaximizeVideo

Firefox add-on Maximize HTML5/Flash video and fill current tab.
Mozilla Public License 2.0
47 stars 10 forks source link

Doesn't work anymore on the new Firefox 79.0 #33

Closed matt00112233 closed 4 years ago

matt00112233 commented 4 years ago

After updating to Firefox 79.0, the add-on doesn't work anymore when I click on the icon, the video becomes red but never get maximized

Annotation 2020-08-01 075437 Annotation 2020-08-01 075437

ettoolong commented 4 years ago

Hi @matt00112233 ,

I can't reproduce this problem, (test on macOS, Firefox 79.0 and 80.0b2)

  1. Can you please check the preference, make sure the option Auto maximize first video element is checked.
  2. Can you try to click on the highlight area to see if the video will get maximized?
vest816 commented 4 years ago

Hello @matt00112233 and @ettoolong

I'm on Firefox 79.0, Windows 10. I think I've pinpointed the issue. I was experiencing the same problem earlier and did some poking around in the app's options menu. It seems the "Keep original controls on YouTube" option was causing it. Try unchecking that, and see if the issue persists.

ettoolong commented 4 years ago

Hi @vest816, @matt00112233, The last update, I remove the tabs permission cause this issue, I should add it back in next update,

Thanks for your feedback.

ettoolong commented 4 years ago

Update v0.0.16 for Firefox

vest816 commented 4 years ago

Just checked and tested around with the different options toggled on and off. Works on Twitch. Works on YouTube. And works on the few other streaming sites I tested it out with. Seems fixed for me! Thanks @ettoolong

matt00112233 commented 4 years ago

Thanks a lot, I'll try later and report back

On Sat, Aug 1, 2020 at 8:45 PM vest816 notifications@github.com wrote:

Just checked and tested around with the different options toggled on and off. Works on Twitch. Works on YouTube. And works on the few other streaming sites I tested it out with. Seems fixed for me! Thanks @ettoolong https://github.com/ettoolong

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ettoolong/MaximizeVideo/issues/33#issuecomment-667622143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIVV7B6JPKKTD6NHOZZUK5LR6TONJANCNFSM4PRVZR3Q .