ettoolong / MaximizeVideo

Firefox add-on Maximize HTML5/Flash video and fill current tab.
Mozilla Public License 2.0
47 stars 10 forks source link

Manifest v3 #64

Closed davisstu closed 2 months ago

davisstu commented 3 months ago

Chrome has indicated that this extension will no longer be supported once it transitions to Manifest v3. Is there a roadmap in place to update the extension to ensure compatibility with Manifest v3?

hyperion4 commented 2 months ago

Chrome has indicated that this extension will no longer be supported once it transitions to Manifest v3. Is there a roadmap in place to update the extension to ensure compatibility with Manifest v3?

I hope it gets updated. But I have the feeling this extension is basically abandoned. The last update was 3 years ago. If it doesn't get updated you can use the Maximize Video userscript instead. Tampermonkey has been updated to MV3 and this Maximize Video script works fine in most sites I have it tested. https://greasyfork.org/en/scripts/4870-maximize-video

davisstu commented 2 months ago

Chrome has indicated that this extension will no longer be supported once it transitions to Manifest v3. Is there a roadmap in place to update the extension to ensure compatibility with Manifest v3?

I hope it gets updated. But I have the feeling this extension is basically abandoned. The last update was 3 years ago. If it doesn't get updated you can use the Maximize Video userscript instead. Tampermonkey has been updated to MV3 and this Maximize Video script works fine in most sites I have it tested. https://greasyfork.org/en/scripts/4870-maximize-video

I fear you might be right. Thanks for the userscript equivalent, though - very handy.

ettoolong commented 2 months ago

Since I've been so busy with my job, I haven't updated this extension in three years. I thought it was still working for the past year. I have updated it to Manifest v3 and I'm waiting for Google review. You can check out the source code in chrome-mv3 branch.

I'm still trying to solve the issue that video element inside the iframe, hoping I'll fix it in the next update.

davisstu commented 2 months ago

@ettoolong It looks like the update has reached the Chrome store. Unfortunately, all functionality has gone. Neither the manual or automatic option work like they did under the previous versions. It just seems to overlay the page, and doesn't focus the video etc like the previous version. Any ideas?

ettoolong commented 2 months ago

@davisstu I just tested it on youtube and twitch and it works fine. Can you disable and re-enable the extension and try again?

截圖 2024-08-19 20 09 51
davisstu commented 2 months ago

@ettoolong Enabled and re-enabled and still the same issue. Doesn't work on YT or Twitch (your use cases either). I was literally using the previous version this morning which worked, then it updated and now it doesn't. I'm on latest stable chrome on MacOS latest, btw.

Testing it in Incognito it works on YouTube but doesn't work on other HTML5 video it previously worked on.

ettoolong commented 2 months ago

@davisstu Can you provide a website URL for me to test?

davisstu commented 2 months ago

@ettoolong A grey area legally but as a test case this is a site I use. All the streams on this site worked with previous version, now none of them do. https://strikeout.im/

ettoolong commented 2 months ago

@davisstu Chrome shows ERR_CONNECTION_REFUSED when I visit this site. 🙁

davisstu commented 2 months ago

@ettoolong Ok try this legit one - same issue https://www.bbc.co.uk/reel/video/p0jgsff2/the-scientists-drilling-into-an-active-icelandic-volcano

ettoolong commented 2 months ago

@ettoolong Ok try this legit one - same issue https://www.bbc.co.uk/reel/video/p0jgsff2/the-scientists-drilling-into-an-active-icelandic-volcano

@davisstu In this case, it will be fixed in version 0.0.23 (waiting for google review), but I have no idea if other sites can be fixed. Obviously, this is a different problem than site strikeout.im.

截圖 2024-08-20 00 25 17
davisstu commented 2 months ago

@ettoolong 0.0.23 has fixed the issues noted above 👍

hyperion4 commented 2 months ago

I've tested the latest MV3 version in every site I was using the MV2 version and it works great in all of them. Thank you @ettoolong for the great update.