search

etwmc / Personal-HomeKit-HAP

This project will provide source code to build a HomeKit support accessories.
MIT License
236 stars 85 forks source link

Make PHK easier to embed into other projects #36

Closed CodingNinja closed 9 years ago

CodingNinja commented 9 years ago

The work that has been done on PHK is a awesome but it is difficult to use PHK as an external library, this is my efforts to make it easier to embed as a dylib.

tbfly commented 9 years ago

https://github.com/CodingNinja/Personal-HomeKit-HAP-/commit/8d7a67931484a3f48319be9195ee98d058fafeda

This commit revert some improved code. I guess you had not pull before commit? :-)

CodingNinja commented 9 years ago

Sorry about that mate, I'll update the pull request to master.

Sent from my iPhone

On 20 Jan 2015, at 5:43 pm, Lu Zhihe notifications@github.com wrote:

CodingNinja@8d7a679

This commit revert some improved code. I guess you had not pull before commit? :-)

— Reply to this email directly or view it on GitHub.

CodingNinja commented 9 years ago

Hey mate, I fixed it up by rebasing against the previous commits and reverting the incorrect merge I did.

A better version of the compare is available at https://github.com/etwmc/Personal-HomeKit-HAP-/pull/36/files?w=1, this omits the whitespace trimming commit.