etxztn / pulpcore

Automatically exported from code.google.com/p/pulpcore
0 stars 0 forks source link

KEY_P seems out of place in Input.java #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Using the Pulp core, we can see the following constants:
KEY_P 64  //Why isn't this set to 80?
KEY_A 65 
KEY_O 79 
.... //There is no entry with a value of 80
KEY_Q 81 

1. Is this a design decision or a bug?

2. If it's a design decision, it should probably be documented more
clearly; I was looping through all possible "letter" key values, and missed
P because of this.

Thanks again; the engine works great, and I've got a workaround for this,
so it's no biggie. :)

Original issue reported on code.google.com by seth.h...@gmail.com on 8 Nov 2007 at 8:39

GoogleCodeExporter commented 8 years ago
Ah, thanks for noticing! It was a typo. 

So, it shouldn't have caused any problems if you were just trying to detect 
when P was pressed, since even 
though it was a typo there were no two keycodes with the same value. However, 
yes, if you were looping 
through A-Z, P would have been skipped.

It's fixed in SVN and will be in 0.10.6.

Original comment by brack...@gmail.com on 10 Nov 2007 at 7:42