search

etyp / meteor-accounts-ldap

A Meteor package for logging in and creating users with LDAP credentials
MIT License
39 stars 23 forks source link

Merge pull request #30

Closed conrad-dk closed 7 years ago

conrad-dk commented 8 years ago

The outstanding pull request by @billiam13s solves two critical bugs. Can we get those merged in or should I create a fork and do it there?

@etyp I guess you aren't too involved with this any more?

etyp commented 7 years ago

@conrad-dk I'm sorry, I've been really swamped and meant to update everyone. I plan on trying to catch up on issues and PRs at some point, but can't make promises on when.

I'm aiming for this weekend when I have extra time. In the meantime, I've added you as a collaborator on the project. Feel free to move forward with PRs.

I've only been hesitant as we have no automated tests in place, so I have had to manually test.

conrad-dk commented 7 years ago

Finally got around to it - it worked perfectly for me, so I've gone ahead and merged the PR.