search

eu-cdse / documentation

Technical documentation for Copernicus Data Space Ecosystem
18 stars 10 forks source link

mermaid_replaced_w_png #563

Closed KanerLev closed 3 months ago

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://eu-cdse.github.io/documentation/pr-preview/pr-563/ on branch gh-pages at 2024-06-26 11:33 UTC

KanerLev commented 3 months ago

Hi @jdries,

We realized mermaids causing actions to take hours and usually fail e.g. for openEO federation see https://github.com/eu-cdse/documentation/actions/runs/9674644637 (and for SentinelHub see: https://github.com/eu-cdse/documentation/pull/561#issuecomment-2191156515)

therefore we would like to replace these mermaid charts with their png equivalent at the moment. -For SentinelHub pages (see above) we had chosen to replace them to merge an urgent PR. -For openEO federation we are now bringing it to your attention.

For the future, if it's not strictly necessary to use mermaid scripts, can we avoid them?

jdries commented 3 months ago

replacing as a quickfix is fine if you are blocked Did someone look into why it is taking so long, or perhaps even log a bug? (If concrete info exists...)

KanerLev commented 3 months ago

Great. To the best of my info, other than me no one else looked at it (as I acted on it only yesterday afternoon). Per concrete info: I only have this: when mermaids are replaced with png, PR are created at a normal speed and they don't fail. With this, I reckon I can go with a bug report in here: https://github.com/quarto-dev/quarto-cli/issues/new/choose

KanerLev commented 3 months ago

Hi again @jdries,

Looking at https://github.com/quarto-dev/quarto-cli/issues/new?assignees=&labels=bug&projects=&template=bug_report.yml I don't think I'll go with reporting it as a bug. I'm not able to complete it up to that standard at the moment.

Instead, if you refuse this PR, I'll take a note of it to troubleshoot it myself and/or seek for an interested party.

KanerLev commented 3 months ago

Noted, thanks. Note: The situation has been stable since I created this PR. Therefore change of plans: I'm closing without merging.

KanerLev commented 3 months ago

I had to remove the mermaid: https://github.com/eu-cdse/documentation/pull/571 again as a hotfix. I created an issue on it: https://github.com/eu-cdse/documentation/issues/572