search

eu-digital-green-certificates / dgc-certlogic-android

This repository contains the source code of the EU Digital COVID Certificate Certlogic for Android.
Apache License 2.0
6 stars 34 forks source link

No support for Android 6 / Minimum SDK incompatible with Corona-Warn-App #17

Open mlenkeit opened 3 years ago

mlenkeit commented 3 years ago

Describe the bug

The minSdk version is currently set to 26 which makes it incompatible with the Corona-Warn-App (CWA).

https://github.com/eu-digital-green-certificates/dgc-certlogic-android/blob/2d315b25eadd39573ba96a6bd77018362f9980e1/buildSrc/src/main/java/AppConfig.kt#L26

CWA needs to support Android 6, so we'll need SDK 23.

Expected behaviour

Support Android 6

Steps to reproduce the issue

n/a

Technical details

https://developer.android.com/about/versions/marshmallow/android-6.0

Possible Fix

Adjust minSdk

Additional context

n/a

vaubaehn commented 3 years ago

If this is not a blocker, you may even consider to set minSdk to 21 to facilitate future implementation into CWA forks (CCTG) that also aim to provide compatibility for Android 5.0. There are still a lot of devices out there...

/cc @fynngodau

oleksandrsarapulovgl commented 3 years ago

PR: https://github.com/eu-digital-green-certificates/dgc-certlogic-android/pull/47 https://github.com/eu-digital-green-certificates/dgc-certlogic-android/pull/48 https://github.com/eu-digital-green-certificates/dgc-certlogic-android/pull/49