search

eu-digital-green-certificates / dgc-overview

This repository provides an overview over the EU Digital Green Certificates (DGC) project.
Apache License 2.0
209 stars 29 forks source link

Issues with evolution off the published JSON schema version #5

Closed pjsramos closed 3 years ago

pjsramos commented 3 years ago

https://ec.europa.eu/health/sites/health/files/ehealth/docs/digital-green-certificates_dt-specifications_en.pdf

I think the published scheme has some problems:

  1. The lack of a "version" field to accommodate future changes to this schema. If more than one version of the DGC is in circulation, validation applications cannot distinguish between them without a version field. This field is present in more recent versions: https://github.com/ehn-digital-green-development/ehn-dgc-schema/blob/main/DGC.schema.json
  2. The datasets for disease-agent-targeted, vaccine-prophylaxis, vaccine-medicinal-product, test-manf, etc are hard-coded in the schema and don't accommodate for the future update of this values to add new vaccines or tests. I think this datasets must be maintained outside of the schema.
SchulzeStTSI commented 3 years ago

@dirkx How is the current state in schema discussions here?

SZoerner commented 3 years ago

By now, the current version 1.0.0 does include a version field as well as separating the value sets from the core schema. @pjsramos do you think this issue can be closed then?

pjsramos commented 3 years ago

@SZoerner this is good news. I think with this changes we can close this issue.