eu-digital-green-certificates / dgc-testdata

Repository for storing generated QR code data for testing.
Apache License 2.0
158 stars 218 forks source link

UVCI checksum specification standardisation request #198

Open kristinaleko opened 3 years ago

kristinaleko commented 3 years ago

Hi all,

we have tested the test data from other countries and we have noticed that there are different interpretations on the UVCI checksum filed in the QR codes.

There are different UVCI formats CURRENTLY in the test data uploaded in this github: urn:uvci:01:GR:78J239D5#2, 01BEVLWZMTR61HYQJ3QTQQGU0RNT#0 urn:uvci:01:NL:b54599fc038c45d79bb8013d0b07406e 6fhkn4275xt78akvs7bh62egw339znys

And on slack there has been a discussion on the UVCI checksum - with no conclusion; the checksum is used in the digital certificates and not on the paper certificates. The question is will this stay so or the checksum will be removed from th edigital QR code also.

The specifications are supposed to be on this page https://github.com/ehn-digital-green-development/ehn-dgc-schema/wiki/FAQ#the-uvci-checksum-used-is-luhn-mod-n-what-is-the-codeset-and-are-there-examples but because of different approaches for implementation we feel it is needed to once more confirm this specs so that all the test data can be evaluated right.

dirkx commented 3 years ago

"the checksum is used in the digital certificates and not on the paper certificates. " - it is just the other way round (see the appendix) -- the checksum is optional for the paper printout where human re-entry is likely.

It is not needed in digital rendition (as they are signed) where there is no re-entry and error correction needed. And they just take up valuable bit space.

So we should not have any checksums in this test repository.