eu-digital-green-certificates / dgc-testdata

Repository for storing generated QR code data for testing.
Apache License 2.0
157 stars 218 forks source link

ES: Incorrect type and values for attributes Issued At and Expiration Time #233

Closed rafalgra closed 3 years ago

rafalgra commented 3 years ago

Affected Country: ES

Issue Description

ES is not using integer NumericDate format for attributes Issued At and Expiration Time in CWT Structure (payload section). Official documentation (https://github.com/ehn-digital-green-development/hcert-spec/blob/main/hcert_spec.md) specifies: 3.3.5 Expiration Time The Expiration Time (exp) claim SHALL hold a timestamp in the integer NumericDate format (as specified in RFC 8392 section 2) indicating for how long this particular signature over the Payload SHALL be considered valid, after which a Verifier MUST reject the Payload as expired. The purpose of the expiry parameter is to force a limit of the validity period of the health certificate. The Claim Key 4 is used to identify this claim.

3.3.6 Issued At The Issued At (iat) claim SHALL hold a timestamp in the integer NumericDate format (as specified in RFC 8392 section 2) indicating the time when the health certificate was created.

Screenshots: image image image

Proposed Solution

Correct the values and type for attributes Issued At and Expiration Time to the format which is required in official documentation (integer NumericDate format (as specified in RFC 8392 section 2).

JChrist commented 3 years ago

Also, the iat field is past the VALIDATIONCLOCK. eg. for 1101.json VALIDATIONCLOCK: 2021-05-17 09:11:47.777Z iat: 2021-05-24 11:18:18.000

Santivicen commented 3 years ago

Hi @rafalgra I have submitted that files with changes on IssuedAt and Expiration fields, could yo check it to close this issue, please?

rafalgra commented 3 years ago

It's okay now :)

vanlooverenkoen commented 3 years ago
{
  1: ES,
  4: 1777072237,
  6: 1621844298.68,
  -260: {
    1: {
      v: [
        {
          ci: 01ES11VBB823DB3EB6D47BA11F09#5,
          co: ES,
          dn: 2,
          dt: 2021-02-06,
          is: ServicioExtremeñodeSalud,
          ma: 729999,
          mp: 729999,
          sd: 2,
          tg: 729999,
          vp: 729999
        }
      ],
      dob: 1989-04-27,
      nam: {
        fn: MARQUEZSANCHEZ,
        gn: JULIA,
        fnt: MARQUEZ<SANCHEZ,
        gnt: JULIA
      },
      ver: 1.0.0
    }
  }
}

The issued at is still a double. testfile: 1101.json

vanlooverenkoen commented 3 years ago

Apparently, 1101.json is not the only one I will create a list with all the files that are still using doubles for ES