search

eu-digital-green-certificates / dgc-testdata

Repository for storing generated QR code data for testing.
Apache License 2.0
157 stars 218 forks source link

PL: EXPECTEDSCHEMAVALIDATION is false due to invalid `co` #246

Open JChrist opened 3 years ago

JChrist commented 3 years ago

Affected Country: PL

Issue Description

The test file 8.json is expected to fail due to invalid co field, not being a valid ISO 3166 country code. However, the schema is a little bit ambiguous on the subject: "description": "Country of Vaccination / Test, ISO 3166 where possible", It is my understanding that verifiers should not reject a certificate when the ISO 3166 code is not valid.

Proposed Solution

If my understanding is correct, then the test file should be changed to expect schema to be valid. Otherwise, we need to be aware that co field must be validated for ISO 3166 and perhaps amend the schema to reflect that.

gregsons commented 3 years ago

Hi @SchulzeStTSI, could you look on above comment? Shall we correct the mentioned test file?