search

eu-digital-green-certificates / dgc-testdata

Repository for storing generated QR code data for testing.
Apache License 2.0
157 stars 218 forks source link

Fixed pull issues #406

Closed ava3a13 closed 2 years ago

ava3a13 commented 2 years ago

@daniel-eder Hello Daniel! Can you review our commit? Thank you in advance!

daniel-eder commented 2 years ago

@ava3a13 can you check out the log for the failed check above? Seems something is not right

ava3a13 commented 2 years ago

@ava3a13 can you check out the log for the failed check above? Seems something is not right

As I see in logs none of the 'GE' data has failed test pass. Should I have done something otherwise?

ava3a13 commented 2 years ago

@daniel-eder Running tests locally on clean repository (Without adding our files), still outputs the same amount of errors. cmd_ck30SnlEB0

And after the addition of files: cmd_wRY5ssydzb

daniel-eder commented 2 years ago

@ava3a13 apologies! Seems there are problems with the data from FI that were not yet marked as known issues. Can you update your fork to the latest commit on the dgc-testdata main branch (it contains the updated issue list and now successfully passes the tests, see https://github.com/eu-digital-green-certificates/dgc-testdata/actions/runs/1294458321) so I can re-run the test?

daniel-eder commented 2 years ago

@ava3a13 thanks a lot, tests confirmed now!

ava3a13 commented 2 years ago

@daniel-eder Thank you!