eu-digital-green-certificates / dgca-validation-service

Validation service can validate eu digital covid certificates for travel and booking services using business rules from dgca-businessrule-service and certificates from dgca-verifier-service.
Apache License 2.0
13 stars 10 forks source link

Unclear error "Test collection date after condition validFrom" and "Condition Failed" is shown for a Technically Valid TEST Certificate #68

Closed RalicaY closed 3 years ago

RalicaY commented 3 years ago

Describe the bug

A technically valid TEST certifiate which is chronologically valid during the time of test (30.09.2021) is submitted for check in via the wallet app.

ATTENTION: Standardised name in the certificate is the same as Given Name.

The certificate is found but an unclear error "Test collection date after condition validFrom" and "Condition Fulfilled" failed is shown in the booking frontend.

Booking_TEST

Expected behaviour

Steps to reproduce the issue

a-trzewik commented 3 years ago

The Test certificate has a field collection date (the date when the test data was collected). This date should be greate as validFrom date of condition.

Example the condition validFrom is 01.10.2021 (it is travel/fly start date) The test collection date is 03.10.2021

The collection date (03.10.2021) is after condition validFrom (01.10.2021)

Probably your condition validFrom (travel start day) is in the past before the test was donw. please check your test data.

chrloch commented 3 years ago

This is the payload of the DCC

{-260: {1: {'dob': '1990-01-01', 'nam': {'fn': 'GleicherName', 'fnt': 'GLEICHERNAME', 'gn': 'Liem', 'gnt': 'LIEM'}, 't': [{'ci': 'URN:UVCI:V1:DE:48D76HNNI7B0VVRXEX4T616C5Z', 'co': 'DE', 'is': 'Issuer Darmstadt IMPF-CENTER ', 'nm': 'Test Joinstar', 'sc': '2021-09-30T22:00:00Z', 'tc': 'Testinf Center Müll', 'tg': '840539006', 'tr': '260415000', 'tt': 'LP6464-4'}], 'ver': '1.3.0'}}, 1: 'DE', 4: 'Timestamp(2021-10-04T00:00:00)', 6: 'Timestamp(2021-09-30T12:56:05)'}

ltranvan commented 3 years ago

Hello, please check again! 1.)- Please remember that just only the owner of a ticket is authorized to close his ticket. Please do not close a ticket but only assign it back to ticket owner for recheck/retest. 2.)- As you can see from the certificate, the Collection datetime is NOT 03.10.2021 but from 30.09.2011. Please for futher analysis you can take the new test certificate from today 04.10.2021 11:00. It leads to the same unexpected failed-result: image image

RalicaY commented 3 years ago

@a-trzewik , could you please reopen this issue? For us it is not closed but only the person who closed it can reopen it, this is why I would like to ask you to reopen it. Thank you very much for your help!

kerstin-oppermann-tsi commented 3 years ago

Issue is fixed by @SchulzeStTSI

Is retested with iOS wallet 1.2.2.1(6) and Android wallet 1.2.4 (20)

@ltranvan issue can be closed