search

eu-digital-green-certificates / dgca-validation-service

Validation service can validate eu digital covid certificates for travel and booking services using business rules from dgca-businessrule-service and certificates from dgca-verifier-service.
Apache License 2.0
13 stars 10 forks source link

Spelling and grammar corrections in README #97

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

I noticed several typos in the README.md document of this repo, so I've submitted a PR which corrects typos and grammar where I was reasonably sure about the correction.

The repo is now cross-referenced by the Corona-Warn-App FAQs, specifically

https://www.coronawarn.app/en/faq/#val_service_basics and https://www.coronawarn.app/de/faq/#val_service_basics which is how I came to be reading here.

MikeMcC399 commented 2 years ago

@daniel-eder

Thank you for approving!

You might notice that this PR is failing the CI check, in common with the other open (auto-generated Dependabot) PRs:

Perhaps somebody could look at resolving the issue with the ci-dependency-check which is unrelated to the content I submitted? It has been failing since Dec 26, 2021. See for instance https://github.com/eu-digital-green-certificates/dgca-validation-service/actions/runs/1622994651.

CC: @SchulzeStTSI

MikeMcC399 commented 2 years ago

@daniel-eder / @SchulzeStTSI

The repository has been failing its own weekly scheduled ci-dependency-check for the past 4 weeks. The last successful run was on Dec 19, 2021. This does not seem consistent with it being named as an EU reference installation.

MikeMcC399 commented 2 years ago

Rebased to retrigger actions.

MikeMcC399 commented 2 years ago

@SchulzeStTSI / @daniel-eder

Will you merge this PR?

daniel-eder commented 2 years ago

@f11h can you merge this at the earliest convenience? It's a readme-only change.

f11h commented 2 years ago

Thanks for your support @MikeMcC399