eu-digital-identity-wallet / eudi-app-android-wallet-ui

EUDI Wallet Prototype
European Union Public License 1.2
51 stars 18 forks source link

Remove tracking #95

Closed Jak2k closed 3 months ago

Jak2k commented 3 months ago

Firebase crashlytics is installed in the application. This is not required for the application to work. It should be completely removed.

stzouvaras commented 3 months ago

Hi @Jak2k ,

The project doesn't use any Firebase tools. There is a convention plugin called "eudi.android.application.firebase," but it is not currently in use. The reason we haven't removed it is in case someone wants to utilize it in the future. The same goes for us; we may need to use it internally for our operations. It doesn't affect the application.

Have you identified any other issues that affect the application?

Jak2k commented 3 months ago

As you can see in gradel's library config, there is firebase analytics included in the project. This is tracking. If the firebase is not being used, that library should be completely removed. There is no valid reason to include a tracking library. When it would be needed in the future, it could be added again.

Jak2k commented 3 months ago

The same goes for Microsoft's tracking: https://github.com/eu-digital-identity-wallet/eudi-app-android-wallet-ui/blob/b3e25725e394b4022114e4a600a6778c48f10c90/gradle/libs.versions.toml#L171

stzouvaras commented 3 months ago

Firebase dependencies and plugins can be removed and re-added in the future if needed.

Microsoft AppCenter is currently being used for internal operations and cannot be removed, at least for now.

Jak2k commented 3 months ago

Microsoft AppCenter is currently being used for internal operations and cannot be removed, at least for now.

For what is it used exactly? Why is it not possible to use a solution like Matomo, which is privacy friendly and open source (and already used by EU institutions)?

stzouvaras commented 3 months ago

Hi @Jak2k ,

It is used for testing purposes, mostly for distribution, both public and internal. This is a temporary solution, and there are plans to switch to a different solution in the near future. Matomo is also being considered.

For now, you can simply remove it from your build. The code is open source, so you can alter it as you please based on your needs